Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<ShowLabels> for bool #7686

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Oct 11, 2024

What

Adding a convenience function to components::ShowLabels.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@grtlr grtlr marked this pull request as ready for review October 11, 2024 07:47
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see why not

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 🍏 primitives Relating to Rerun primitives include in changelog labels Oct 14, 2024
@teh-cmc teh-cmc merged commit ca6ad40 into rerun-io:main Oct 14, 2024
7 of 8 checks passed
@emilk emilk added 🦀 Rust API Rust logging API and removed include in changelog labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🍏 primitives Relating to Rerun primitives 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants