Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun_py.dataframe: Add APIs for using_index_values, fill_latest_at, and filter_is_not_null #7680

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 10, 2024

What

TODO

  • The unit test currently fails with what looks like a bug

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs marked this pull request as ready for review October 10, 2024 16:24
@jleibs jleibs added feat-dataframe-api Everything related to the dataframe API exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API labels Oct 10, 2024
@teh-cmc teh-cmc self-requested a review October 11, 2024 07:28
@teh-cmc
Copy link
Member

teh-cmc commented Oct 11, 2024

I'll rebase this on top of #7683 -- that should fix that test.

@teh-cmc teh-cmc force-pushed the jleibs/py_dataframe_more_apis branch from 5b83cf7 to 27492ca Compare October 11, 2024 07:31
@teh-cmc teh-cmc changed the base branch from main to cmc/dataframev2_hindsight October 11, 2024 07:32
@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label Oct 11, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Oct 11, 2024

$ pixi run -e py py-test 2>&1 > /dev/null ; echo $?
0

Comment on lines 64 to 65
The index values returned will be the intersection between the provided values and the
original index.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The index values returned will be the intersection between the provided values and the
original index.
The index values returned will be the intersection between the provided values and the
original index values.

@teh-cmc teh-cmc force-pushed the cmc/dataframev2_hindsight branch from 8e5a8d7 to 1ebc0ba Compare October 11, 2024 13:00
Base automatically changed from cmc/dataframev2_hindsight to main October 11, 2024 13:07
@teh-cmc teh-cmc force-pushed the jleibs/py_dataframe_more_apis branch from b30c535 to 9b30391 Compare October 11, 2024 13:07
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Oct 11, 2024
@jleibs jleibs merged commit b69be17 into main Oct 11, 2024
36 checks passed
@jleibs jleibs deleted the jleibs/py_dataframe_more_apis branch October 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand python APIs to support new data API concepts
3 participants