Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty column tracker and new dataframe APIs on top #7677

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Empty column tracker and new dataframe APIs on top #7677

merged 5 commits into from
Oct 11, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 10, 2024 •
edited by github-actions bot
Loading

Before:
image

After:
image

Of course with static data this still looks pretty weird in many cases, such as shown in this screenshot,
But that's a job for the upcoming #7668.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🔍 re_query affects re_query itself include in changelog feat-dataframe-api Everything related to the dataframe API labels Oct 10, 2024
@teh-cmc teh-cmc force-pushed the cmc/store_empty_writes branch 3 times, most recently from b3cde2b to 11f9156 Compare October 10, 2024 16:18
@teh-cmc teh-cmc marked this pull request as ready for review October 10, 2024 16:24
@teh-cmc teh-cmc force-pushed the cmc/store_empty_writes branch from 11f9156 to f5b5d3c Compare October 10, 2024 16:26
@teh-cmc teh-cmc force-pushed the cmc/store_empty_writes branch from f5b5d3c to 7ba19c7 Compare October 10, 2024 16:27
@teh-cmc teh-cmc mentioned this pull request Oct 10, 2024
Merged
6 tasks
@abey79 abey79 mentioned this pull request Oct 11, 2024
Open
jleibs
jleibs approved these changes Oct 11, 2024
View reviewed changes
crates/store/re_chunk_store/src/dataframe.rs
Comment on lines +194 to +204

/// Whether this column represents an indicator component.
pub is_indicator: bool,

/// Whether this column represents a [`Clear`]-related components.
///
/// [`Clear`]: re_types_core::archetypes::Clear
pub is_tombstone: bool,

/// Whether this column contains either no data or only contains null and/or empty values (`[]`).
pub is_semantically_empty: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just expose ColumnMetadata here directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eeeh, as this is the heart of the API, I'd prefer to keep it flat, simple to inspect and simple to build by hand.

@teh-cmc teh-cmc merged commit c23bbed into main Oct 11, 2024
34 checks passed
@teh-cmc teh-cmc deleted the cmc/store_empty_writes branch October 11, 2024 12:59
teh-cmc added a commit that referenced this pull request Oct 11, 2024
@teh-cmc
Dataframe v2: big ol' hindsight-driven refactoring (#7683)
9f23ae0 
Simpler. Faster. Correct-er.

* Fixes #7681
* DNM: requires #7677
@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API 🔍 re_query affects re_query itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataframe: track and exclude fully empty columns
3 participants
@teh-cmc @jleibs @emilk