-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rerun_py.dataframe: add support for .filter_index_values #7670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
🐍 Python API
Python logging API
exclude from changelog
PRs with this won't show up in CHANGELOG.md
feat-dataframe-api
Everything related to the dataframe API
labels
Oct 9, 2024
jleibs
force-pushed
the
jleibs/py_dataframe_filter_index_values
branch
from
October 9, 2024 20:41
7a2d69b
to
23a7912
Compare
jleibs
force-pushed
the
jleibs/py_dataframe_filter_index_values
branch
from
October 9, 2024 21:09
0bf15a1
to
e04c513
Compare
teh-cmc
approved these changes
Oct 10, 2024
rerun_py/src/dataframe.rs
Outdated
@@ -195,6 +196,108 @@ impl AnyComponentColumn { | |||
} | |||
} | |||
|
|||
#[derive(FromPyObject)] | |||
enum IndexLike<'py> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IndexLike
is a misleading name: this does not represent an index, it represents a series of index values. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, good call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude from changelog
PRs with this won't show up in CHANGELOG.md
feat-dataframe-api
Everything related to the dataframe API
🐍 Python API
Python logging API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
numpy
package for ArrayLike functionalitynumpy
has an old dep on ndarray.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.