Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun_py.dataframe: add support for .filter_index_values #7670

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 9, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API labels Oct 9, 2024
@jleibs jleibs force-pushed the jleibs/py_dataframe_filter_index_values branch from 7a2d69b to 23a7912 Compare October 9, 2024 20:41
@jleibs jleibs marked this pull request as ready for review October 9, 2024 20:41
@jleibs jleibs force-pushed the jleibs/py_dataframe_filter_index_values branch from 0bf15a1 to e04c513 Compare October 9, 2024 21:09
@@ -195,6 +196,108 @@ impl AnyComponentColumn {
}
}

#[derive(FromPyObject)]
enum IndexLike<'py> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IndexLike is a misleading name: this does not represent an index, it represents a series of index values. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good call.

@jleibs jleibs merged commit 370d992 into main Oct 10, 2024
35 checks passed
@jleibs jleibs deleted the jleibs/py_dataframe_filter_index_values branch October 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants