Small video-related refactor #7660
Conversation
emilk
added
🚜 refactor
emilk
changed the title
| @@ -55,5 +60,6 @@ pub struct Frame { | |||
| } | |||
|
|
|||
| pub enum PixelFormat { | |||
| Rgb8Unorm, | |||
There was a problem hiding this comment.
it doesn't have to be though, we can choose that fairly freely, no?
There was a problem hiding this comment.
Not completely freely. We can pcik rgb24, but not rgba32, for instance
There was a problem hiding this comment.
We can pick some yuv formats for sure, but we didn't have GPU support for that when I wrote this code.
| @@ -174,6 +175,9 @@ impl GroupOfPictures { | |||
| /// A single sample in a video. | |||
| #[derive(Debug, Clone)] | |||
| pub struct Sample { | |||
| /// The start of a new [`GroupOfPictures`]? | |||
There was a problem hiding this comment.
why the question mark? That is how we defined them, no?
There was a problem hiding this comment.
This is the question the boolean answers
| @@ -55,5 +60,6 @@ pub struct Frame { | |||
| } | |||
|
|
|||
| pub enum PixelFormat { | |||
| Rgb8Unorm, | |||
There was a problem hiding this comment.
it doesn't have to be though, we can choose that fairly freely, no?
| return copy_video_frame_to_texture( | ||
| queue, | ||
| &Frame { | ||
| data: crate::pad_rgb_to_rgba(&frame.data, 255_u8), |
There was a problem hiding this comment.
I'd be a lot happier if this goes through texture manager's format conversions that landed on main now because that's what is going to happen with AV1 output now
There was a problem hiding this comment.
Of course - that's part of #7608. But that's a much bigger PR than this one.
What
Some small improvements in service of coming ffmpeg stuff
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.