Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe v2: never mention indicator components #7656

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Dataframe v2: never mention indicator components #7656

merged 3 commits into from
Oct 9, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 9, 2024 •
edited by github-actions bot
Loading

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added enhancement New feature or request 🔍 re_query affects re_query itself include in changelog labels Oct 9, 2024
@teh-cmc teh-cmc merged commit a2705b7 into main Oct 9, 2024
35 checks passed
@teh-cmc teh-cmc deleted the cmc/dataframev2_no_indicators branch October 9, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request 🔍 re_query affects re_query itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't return IndicatorComponents from the dataframe APIs
3 participants
@teh-cmc @jleibs @emilk