-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataframe v2: support for clear semantics #7652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
enhancement
New feature or request
🔍 re_query
affects re_query itself
do-not-merge
Do not merge this PR
include in changelog
labels
Oct 9, 2024
teh-cmc
force-pushed
the
cmc/dataframev2_clears
branch
from
October 9, 2024 12:54
0884d76
to
70a2634
Compare
jleibs
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I like this partitioning. Makes it easier to cache/optimize fetch_clear_chunks
in the future with some additional data-structures + the component-refactoring we've discussed.
6 tasks
teh-cmc
force-pushed
the
cmc/dataframev2_clears
branch
from
October 10, 2024 07:19
a1410df
to
5f92358
Compare
Deployed docs
|
measure clear_chunks timings
teh-cmc
force-pushed
the
cmc/dataframev2_clears
branch
from
October 10, 2024 07:21
5f92358
to
96dbdac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support clear semantics in the dataframe API.
Tombstones are never visible to end-users, only their effect.
Like every other Dataframe v2 feature PR, and following recommendations from @jleibs, this prioritizes convenience of implementation over everything else, for now.
All clear chunks are fetched, post-processed, and re-injected into the view contents during init(), and then the streaming join runs as usual after that.
Static clear semantics can get pretty unhinged, but that's A) not specific to the dataframe API and B) so extremely niche that our time is better spent on real-world problems right now:
Clear
semantics are under-defined and very confusing #7650re_query
recursive clear checks are incorrect #7631Clear
handling issues in dataframe range queries #7468Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.