Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable glam asserts in debug builds #7618

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Enable glam asserts in debug builds #7618

merged 1 commit into from
Oct 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 7, 2024

What

From https://docs.rs/glam/latest/glam/#glam-assertions:

glam does not enforce validity checks on method parameters at runtime. For example methods that require normalized vectors as input such as Quat::from_axis_angle(axis, angle) will not check that axis is a valid normalized vector. To help catch unintended misuse of glam the debug-glam-assert or glam-assert features can be enabled to add checks ensure that inputs to are valid.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 7, 2024
@emilk emilk merged commit e2a7dc9 into main Oct 7, 2024
35 checks passed
@emilk emilk deleted the emilk/glam-asserts branch October 7, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant