Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VideoDecoder a trait #7577

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Make VideoDecoder a trait #7577

merged 1 commit into from
Oct 3, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 3, 2024 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 3, 2024
@emilk emilk marked this pull request as ready for review October 3, 2024 09:25
@Wumpf Wumpf self-requested a review October 3, 2024 09:26
Wumpf
Wumpf approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was more straight forward than I thought, nice :)

@Wumpf Wumpf merged commit e6f93d8 into main Oct 3, 2024
36 checks passed
@Wumpf Wumpf deleted the emilk/video-decoder-trait branch October 3, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality 🎞️ video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf