-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSRV to Rust 1.79 #7563
Merged
Merged
Update MSRV to Rust 1.79 #7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed docs
|
emilk
added
🧑💻 dev experience
developer experience (excluding CI)
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🚢 CI
🦀 Rust API
Rust logging API
include in changelog
and removed
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Oct 2, 2024
This was referenced Oct 2, 2024
Wumpf
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Scary crash. Tried it as well and repros on Mac M1. Want to give it a spin on Windows x64
I got the crash on the second thing it wants to call collect on
I got curious about this crash and enabled the crashy bool. It actually passes one for me and then fails on the first:
```[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:141:17] std::any::type_name::<T>() = "re_renderer::global_bindings::FrameUniformBuffer"
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:142:17] std::mem::size_of::<T>() = 256
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:143:17] std::mem::align_of::<T>() = 256
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:144:17] vec.len() = 1
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:145:17] vec.as_ptr() = 0x000004d5dc085f00
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:146:17] vec.as_ptr() as usize % std::mem::align_of::<T>() = 0
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:147:17] vec.as_slice().len() = 1
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:141:17] std::any::type_name::<T>() = "re_renderer::renderer::compositor::gpu_data::CompositeUniformBuffer"
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:142:17] std::mem::size_of::<T>() = 256
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:143:17] std::mem::align_of::<T>() = 256
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:144:17] vec.len() = 1
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:145:17] vec.as_ptr() = 0x000004d5dc081180
[crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs:146:17] vec.as_ptr() as usize % std::mem::align_of::<T>() = 128
thread 'main' panicked at 'unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`'
... only that I actually get incorrect alignment.
edit: Same on Windows.
that's a bit worrisome
emilk
commented
Oct 3, 2024
crates/viewer/re_renderer/src/allocator/cpu_write_gpu_read_belt.rs
Outdated
Show resolved
Hide resolved
emilk
added a commit
to rerun-io/rerun_template
that referenced
this pull request
Oct 3, 2024
6 tasks
Wumpf
pushed a commit
that referenced
this pull request
Oct 3, 2024
### What #7563 introduced a lint that clippy chokes on with the codegen'd rust. This PR switches off that lint in the offending places. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7578?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7578?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7578) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
This was referenced Oct 4, 2024
emilk
added a commit
that referenced
this pull request
Oct 7, 2024
### What * Part of #7298 ### What Supports native decoding of AV1 videos. Downsides: it is extremely slow in debug builds In release builds it is ok, but there is still A LOT of performance on the table. ### TODO before merging * #7563 * [x] Re-add `nasm` to `pixi.toml`, because it is needed to compile `rav1d` * [x] Make the asm-features of `rav1d` opt-in so users don't need `nasm` to compile `rerun` * [x] Put it behind a feature flag, in case compiling `rav1d` is difficult on some platforms * [x] Fix error handling so we don't crash on bad videos * ~Fix performance of debug builds, if possible~ * `dav1d` is always fast, but `rav1d` is super-slow in debug builds * [x] Or show error message in debug builds * [x] Review moved mp4 demux code to see nothing was lost ### Proof https://github.com/user-attachments/assets/1b1a0a03-9fac-4fa2-bcae-7beb9591067c ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7557?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7557?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7557) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: jprochazk <[email protected]> Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧑💻 dev experience
developer experience (excluding CI)
include in changelog
🦀 Rust API
Rust logging API
🚢 CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
TODO
MiMalloc bug
Debug assertions are now part of stdlib: https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html#asserting-unsafe-preconditions, making us hit this bug in MiMalloc:
mimalloc
returns non-aligned memory purpleprotocol/mimalloc_rust#128I also opened this issue on the standard library:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.