-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Undo/Redo support in the viewer #7546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
enhancement
New feature or request
📺 re_viewer
affects re_viewer itself
include in changelog
labels
Sep 29, 2024
emilk
force-pushed
the
emilk/undo
branch
2 times, most recently
from
October 6, 2024 15:19
d4b0b9c
to
644c87c
Compare
teh-cmc
added a commit
that referenced
this pull request
Oct 7, 2024
### What Adds `ChunkStore::drop_time_range` to drop all events within some time range. Will be used to implement undo. * Part of #3135 * Extracted from #7546 --------- Co-authored-by: Clement Rey <[email protected]>
emilk
force-pushed
the
emilk/undo
branch
5 times, most recently
from
November 8, 2024 15:49
5b9aa8d
to
e4dbc86
Compare
This is blocked by: |
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
commented
Nov 29, 2024
teh-cmc
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ChunkStore::drop_time_range
#7602ViewportBlueprint
logic #8241This PR implements Undo and Redo for any edit to the active blueprint.
undo.mp4
Implementation
This implements undo/redo by editing the "time cursor" for the blueprint timeline. Undo moves it backwards, redo forwards. When doing an action, all redo history is erased from the store with a new
ChunkStore::drop_time_range
function.Known shortcomings
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.