Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe view now has zebra stripes on every line #7434

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 17, 2024

What

This PR adds zebra stripes to all dataframe view lines. Before, when a row was extend to show instances (#7400), those additional lines weren't striped. Also, the alternating colour is now a bit more visible.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface feat-dataframe-view Everything related to the dataframe view include in changelog labels Sep 17, 2024
@Wumpf Wumpf self-requested a review September 18, 2024 07:53
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Wumpf Wumpf merged commit 80cde64 into main Sep 18, 2024
35 of 37 checks passed
@Wumpf Wumpf deleted the antoine/instances-have-zebra-stripes branch September 18, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants