Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Uses the latest egui containing this gem:
Context::request_discard
for multi-pass layouts emilk/egui#5059So far
request_discard
(running a second pass) is only used in these situations:Grid
first shows upegui_table
rowOf course, running a second pass has some costs. Luckily, we already execute our most expensive stuff (the viewport) last, and so we can easily early-out from things like point cloud upload/rendering, as shown in this puffin-capture of a frame with two passes in it:
NOTE: this flamegraph is of a DEBUG build - the point is not the relative times, but that
pass 0
becomes very cheap, if therequest_discard
is called from one of the non-viewport panels (e.g. the selection panel).There might still be cases where we do expensive stuff twice, e.g. if something calls
request_discard
in a space view tooltip.If we come to regret this, we can disable all second passes by setting
egui::Options::max_passes
to1
.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.