-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utils & snippets for manually logged VideoFrameReference
#7403
Conversation
148f9fc
to
8d4ad66
Compare
Deployed docs
|
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/10828719828 |
rr.send_columns( | ||
"video", | ||
times=[rr.TimeSecondsColumn("video_time", times)], | ||
components=[rr.VideoFrameReference.indicator(), rr.components.VideoTimestamp.seconds(times)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to also set the entity path for illustration (and testing) purposes, but this makes it pretty complex quickly since all columns need to be the same length and one wouldn't want to log the entity path many times 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misremembering: Didn't we say we would exclude that feature for now, and have the entity path be implicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was suggested but at that time I already implemented it because it was fairly trivial to do. It has been suggested to make use of this by adding an example that combines several videos on a single entity
main build actually came back red! |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/10829675382 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod typos
What
TimeColumn::new_seconds/new_nanos
creating sequence timelines #7402A bit of a first: I'm referencing the same examples on both the
AssetVideo
and theVideoFrameReference
archetype, seems to make sense :)Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.