Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mp4 rev #7382

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Update mp4 rev #7382

merged 4 commits into from
Sep 10, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Sep 9, 2024 •
edited by github-actions bot
Loading

What

  • Update mp4 to latest main, fixing panic when loading files with multiple tracks (audio and video)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Sep 9, 2024
@jprochazk
Copy link
Member Author

Tested with drag-and-drop:

image

emilk
emilk reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of new dependencies here - I assume they are all related to AV1 decoding, and will hopefully be used soon

@jprochazk
Copy link
Member Author

jprochazk commented Sep 10, 2024 •
edited
Loading

It seems like I brought in chunks of a lockfile from a different branch, which I didn't mean to do

@jprochazk
Copy link
Member Author

Looks a lot better now

@jprochazk jprochazk merged commit ef26bf8 into main Sep 10, 2024
7 of 19 checks passed
@jprochazk jprochazk deleted the jan/update-mp4-0 branch September 10, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk left review comments

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jprochazk @emilk @abey79