Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add point-of-view entity and component to the dataframe view's UI #7331

Merged
merged 13 commits into from
Sep 4, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 2, 2024

What

This PR updates the dataframe query override UI as per design in #7279, in particular adding PoV entity and component.

  • updated UI layout
  • time boundaries default to +∞/–∞ button which, when clicked, turn into editable time drag value
  • reset buttons to go back to the state
  • auto-selection of PoV component based on PoV entity (picks a required component for one of the entity archetypes)

Note:

new_dataframe_query_ui.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 changed the title WIP: add PoV entity/component to dataframe view Add point-of-view entity and component to the dataframe view's UI Sep 3, 2024
@abey79 abey79 added ui concerns graphical user interface include in changelog labels Sep 3, 2024
@abey79 abey79 marked this pull request as ready for review September 3, 2024 07:55
@emilk emilk self-requested a review September 4, 2024 13:45
@emilk
Copy link
Member

emilk commented Sep 4, 2024

The "Time range table order" has more indentation than the rest
image

@abey79
Copy link
Member Author

abey79 commented Sep 4, 2024

The "Time range table order" has more indentation than the rest image

I'm gonna let that one slide. I don't have control on that bit of UI (auto-derived from blueprint archetype), and it's going away anyways:

@abey79 abey79 merged commit fed60d4 into main Sep 4, 2024
40 checks passed
@abey79 abey79 deleted the antoine/add-pov-to-range-query branch September 4, 2024 14:27
@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants