Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main build #7139

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Fix main build #7139

merged 1 commit into from
Aug 11, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 11, 2024

What

Main broken by #7128, which missed an updated to code recently introduced (#7071)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Conflict between #7071 and #7128
@abey79 abey79 added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 11, 2024
@abey79 abey79 merged commit 4a3420c into main Aug 11, 2024
36 checks passed
@abey79 abey79 deleted the antoine/fix-main branch August 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant