Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor view colormap settings are now available from blueprint #6577

Closed
wants to merge 5 commits into from

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 14, 2024

What

Usage example:

blueprint = rrb.Blueprint(
    rrb.TensorView(
        origin="tensor",
        name="Tensor",
        # Set a custom colormap & gamma. See `rr.components.Colormap` for which colormaps are available.
        colormap=rrb.ScalarColormap(colormap="turbo", gamma=1.5),
    ),
    collapse_panels=True,
)

Naturally, this comes with the updated & more powerful ui:
image

@ reviewer: lots of indentation changes, don't forget to disable whitespace diff!

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🟦 blueprint The data that defines our UI include in changelog labels Jun 14, 2024
@Wumpf Wumpf mentioned this pull request Jun 14, 2024
10 tasks
Copy link

github-actions bot commented Jun 14, 2024

Deployed docs

Commit Link
55655e9 https://landing-o2gmkrt20-rerun.vercel.app/docs

@Wumpf
Copy link
Member Author

Wumpf commented Jun 17, 2024

looking at this I'm not sure if it should be ScalarColormap. Might as well call it TensorColormap 🤔
Feedback welcome!

@Wumpf
Copy link
Member Author

Wumpf commented Jun 17, 2024

@Wumpf Wumpf closed this Jun 17, 2024
@Wumpf Wumpf deleted the andreas/tensor-colormap-config branch June 17, 2024 14:23
Wumpf added a commit that referenced this pull request Jun 17, 2024
### What

Example:
```python
blueprint = rrb.Blueprint(
    rrb.TensorView(
        origin="tensor",
        name="Tensor",
        # Set a scalar mapping with a custom colormap, gamma and magnification filter.
        scalar_mapping=rrb.TensorScalarMapping(colormap="turbo", gamma=1.5, mag_filter="linear"),
        # Change sizing mode to keep aspect ratio.
        view_fit="FillKeepAspectRatio",
    ),
    collapse_panels=True,
)
```

As always with these ports, this comes with the usual ui refresh:

![image](https://github.com/rerun-io/rerun/assets/1220815/f4f1c79a-c4cb-4373-a7db-ad5a7576dcff)


* Part of #6083
* Replaces / joins
     * #6577
     * #6583

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6585?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6585?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6585)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Wumpf added a commit that referenced this pull request Jun 19, 2024
### What

Example:
```python
blueprint = rrb.Blueprint(
    rrb.TensorView(
        origin="tensor",
        name="Tensor",
        # Set a scalar mapping with a custom colormap, gamma and magnification filter.
        scalar_mapping=rrb.TensorScalarMapping(colormap="turbo", gamma=1.5, mag_filter="linear"),
        # Change sizing mode to keep aspect ratio.
        view_fit="FillKeepAspectRatio",
    ),
    collapse_panels=True,
)
```

As always with these ports, this comes with the usual ui refresh:

![image](https://github.com/rerun-io/rerun/assets/1220815/f4f1c79a-c4cb-4373-a7db-ad5a7576dcff)

* Part of #6083
* Replaces / joins
     * #6577
     * #6583

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6585?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6585?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6585)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant