Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not read query in embedded web viewer #6515

Merged
merged 25 commits into from
Jul 2, 2024
Merged

Do not read query in embedded web viewer #6515

merged 25 commits into from
Jul 2, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Jun 7, 2024 •
edited by github-actions bot
Loading

What

By removing usage of query_map, we no longer read the user's query if they didn't mean for the viewer to read it. History state is now stored in the object rather than the URL.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser include in changelog labels Jun 7, 2024
@jprochazk jprochazk added this to the 0.17 milestone Jun 11, 2024
@jprochazk jprochazk marked this pull request as ready for review July 2, 2024 13:10
@jprochazk jprochazk requested a review from emilk July 2, 2024 13:13
emilk
emilk approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get this all cleaned up!

.vscode/settings.json Outdated Show resolved Hide resolved
crates/re_viewer/src/app.rs Show resolved Hide resolved
web_viewer/index.html Outdated Show resolved Hide resolved
web_viewer/index.html Outdated Show resolved Hide resolved
scripts/lint.py Outdated Show resolved Hide resolved
crates/re_viewer/src/web_tools.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/web_tools.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/web_tools.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/web_tools.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/web_tools.rs Outdated Show resolved Hide resolved
@jprochazk jprochazk merged commit 4ee7634 into main Jul 2, 2024
35 checks passed
@jprochazk jprochazk deleted the jan/remove-query-map branch July 2, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

Remove usage of query_map from web viewer
2 participants
@jprochazk @emilk