-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new archetype for Axes3D #6510
Conversation
Deployed docs
|
proper link for web build: https://rerun.io/viewer/pr/6510?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, lots of this is way over my head, but lets not block that on Andreas being back to office :)
Curious about what you think is needed to make the switch to enabling override_ui
for this space view (instead of using the feature flag) and remove the legacy UI entirely?
On that note, II wasn't able to add a AxisLength component override in the UI, other than by manipulating the legacy UI. Is that expected?
d49d49a
to
f61437c
Compare
f61437c
to
ecc2aa6
Compare
d4aa146
to
62c354a
Compare
This PR seems to have broken CI: https://github.com/rerun-io/rerun/actions/runs/9436507239/job/25991550784 In particular, It seems we don't run the roundtrip tests on each PR (understandable), but that means we miss adding roundtrip tests when we need them. We should have a fast CI job that only checks that we have roundtrip tests, without running them. Fix coming in #6524 |
`main` CI is failing: https://github.com/rerun-io/rerun/actions/runs/9436507239/job/25991550784 #6510 added a new archetype (`Axes3D`) without adding roundtrip tests for it. This was easily missed because the PR CI doesn't run the roundtrip tests. This PR adds a fast PR CI check to make sure we have roundtrip tests for all archetype, but without paying the cost of actually running them. The failure looks like this: ![image](https://github.com/rerun-io/rerun/assets/1148717/61bf60b6-4a88-4f13-be65-917741d7aff8) This PR also adds an exception for the `Axes3D` archetype. I've created a separate issue for that, adding it to this cycle: * #6525 --- * [x] I love checkboxes
What
This replaces the axes-related entity properties with a new Axes3D archetype.
The archetype allows overriding the axis-length from code.
Controlling whether the axes are visible now happens via enabling of the visualizer.
We use similar heuristics to before to enable axes3d visualizers on transforms in certain situations.
The legacy UI has been remapped to the new indicator/heuristics implementation.
TODO:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.