Remove ReUi and move its methods to egui::{Ui|Context} extension traits and to DesignTokens
#6506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/re_data_ui/src/image.rs # crates/re_data_ui/src/instance_path.rs # crates/re_space_view/src/view_property_ui.rs # crates/re_space_view_spatial/src/view_2d.rs # crates/re_viewer_context/src/test_context.rs
abey79
added
🚜 refactor
abey79
changed the title
ReUi and move its methods to egui::{Ui|Context} extension traits and to DesignTokens
# Conflicts: # crates/re_blueprint_tree/src/blueprint_tree.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
re_uiUI functions to a trait to be implemented byegui::Ui#4569This PR:
UiExtandContextExtextension traits foregui::Ui, resp.egui::Context.DesignTokenssuch that it's globally available viare_ui::design_token().re_ui::apply_style_and_install_loaders(&egui::Context)function is introduced to initialise Rerun style in egui.ReUiis removed, and it's methods are dispatched toDesignTokens,ContextExt, andUiExt, depending on their nature.re_ui::ReUireferences are removed from the code base. Some structures which formerly held aReUinow hold aegui::Contextinstead (includingAppandViewerContext).clippy.tomlto forbid the use of someeguifunctions/type that are replaced by our own (e.g.checkbox()andradio_value()). Cleaned up a redundant lint to that effect inscripts/lint.py.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.