Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use test context in component override tests #6499

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 5, 2024

What

This refactor was originally a required part of something else I had to discard again. Salvaged these improvements and usages to the TestContext since since I found it independently useful and more concise than before.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🔨 testing testing and benchmarks 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jun 5, 2024
@Wumpf Wumpf merged commit 4b4cded into main Jun 5, 2024
37 checks passed
@Wumpf Wumpf deleted the andreas/use-textctx-in-override-tests branch June 5, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants