Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass view state through to visualizer systems #6483

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 3, 2024

What

.. and some cleanup on the way

This is an important piece that allows us to move arbitrary heuristics to visualizer implemented fallbacks.
(Fixes main build failure caused by a merge order issue - view systems started using the ViewContext struct before they had access to the view state)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

.. and some cleanup on the way
@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jun 3, 2024
@Wumpf Wumpf changed the title Pass view state through to view systems Pass view state through to visualizer systems Jun 3, 2024
@emilk emilk self-requested a review June 3, 2024 14:31
crates/re_viewer_context/src/space_view/view_states.rs Outdated Show resolved Hide resolved
crates/re_viewport/src/system_execution.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit dc3b75e into main Jun 3, 2024
27 of 28 checks passed
@Wumpf Wumpf deleted the andreas/pass-view-state-to-visualizers branch June 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants