Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using validity bitmaps in Rust union serialization #6236

Merged
merged 5 commits into from
May 7, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 6, 2024

What

Simplifies the rust serialization of unions. Disallowed the use of nullable union fields in the process.
Unfortunately this makes the codegen overall more complicated, not less. There's definitely some low hanging fruit to turn this around, but it eluded my grasp - every attempt to formulate more general rules got stuck on some other failure case.

Run cargo test -p re_types and pixi run python ./tests/roundtrips.py.

  • Run main tests

(branch name is a misnomer, too late to change)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

Disallow the use of nullable union fields.
@Wumpf Wumpf added codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 6, 2024
@Wumpf
Copy link
Member Author

Wumpf commented May 6, 2024

@rerun-bot full-check

Copy link

github-actions bot commented May 6, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/8971221018

@Wumpf
Copy link
Member Author

Wumpf commented May 6, 2024

passed main tests, phew

@Wumpf
Copy link
Member Author

Wumpf commented May 6, 2024

@rerun-bot full-check

Copy link

github-actions bot commented May 6, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/8974934710

@Wumpf Wumpf requested a review from emilk May 7, 2024 07:24
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Wumpf Wumpf merged commit f0e1d32 into main May 7, 2024
72 of 74 checks passed
@Wumpf Wumpf deleted the andreas/simplify-rust-python-serialization branch May 7, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants