-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using validity bitmaps in Rust union serialization #6236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow the use of nullable union fields.
Wumpf
added
codegen/idl
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
May 6, 2024
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/8971221018 |
emilk
reviewed
May 6, 2024
emilk
reviewed
May 6, 2024
passed |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/8974934710 |
emilk
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Simplifies the rust serialization of unions. Disallowed the use of nullable union fields in the process.
Unfortunately this makes the codegen overall more complicated, not less. There's definitely some low hanging fruit to turn this around, but it eluded my grasp - every attempt to formulate more general rules got stuck on some other failure case.
Run
cargo test -p re_types
andpixi run python ./tests/roundtrips.py
.main tests
(branch name is a misnomer, too late to change)
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.