Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selection of entities directly in the plot space view #4959

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Allow selection of entities directly in the plot space view #4959

merged 6 commits into from
Jan 31, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 30, 2024 •
edited
Loading

What

Wires up the new plot item ids to our hover/selection mechanism.
Moved a utility method from item_ui to ViewerContext since I didn't want to take a dependency on re_data_ui here (and this method had a todo about being in the wrong spot anyways 😄 )

more.clicking.mov

DRAFT: Uses unpublished egui version!

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added enhancement New feature or request 📺 re_viewer affects re_viewer itself include in changelog labels Jan 30, 2024
@Wumpf Wumpf force-pushed the andreas/select-plot-entity branch 2 times, most recently from 571c37e to 230798e Compare January 30, 2024 09:59
@nikolausWest
Copy link
Member

Fyi: Bar charts aren't clickable

@Wumpf
Copy link
Member Author

Wumpf commented Jan 30, 2024

Let's fix that as well, should be easy now!

@Wumpf Wumpf force-pushed the andreas/select-plot-entity branch from 230798e to 1afc771 Compare January 30, 2024 15:25
@Wumpf Wumpf marked this pull request as ready for review January 30, 2024 15:25
@Wumpf
Copy link
Member Author

Wumpf commented Jan 30, 2024

done! now also works with bar charts. Thanks for checking on it @nikolausWest :)

Now based on egui master, ready for review! 🚢

@emilk emilk self-requested a review January 30, 2024 15:57
emilk
emilk approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

Cargo.toml
egui_plot = { git = "https://github.com/emilk/egui.git", rev = "ab39420c2933d2e402999043375b64e7cf0ee9ed" } # egui master 2024-01-29
egui-wgpu = { git = "https://github.com/emilk/egui.git", rev = "ab39420c2933d2e402999043375b64e7cf0ee9ed" } # egui master 2024-01-29
emath = { git = "https://github.com/emilk/egui.git", rev = "ab39420c2933d2e402999043375b64e7cf0ee9ed" } # egui master 2024-01-29
ecolor = { git = "https://github.com/emilk/egui.git", rev = "ca513ce241c6511275e92b05b2953c38fa6086e1" } # egui Ids on plot items. 2024-01-30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly weird comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this used to just say the branch name. Eh whatever, not gonna torture ci with this again now when it's about to be changed again 😄

@emilk
Copy link
Member

emilk commented Jan 30, 2024

I wish egui_plot would highlight a line when you hover it though - the lines don't feel clickable now, even though they are

@Wumpf
Copy link
Member Author

Wumpf commented Jan 30, 2024 •
edited
Loading

I noticed that when you hover on a thing in the legend it actually highlights by boosting the size 🤔
But I don't think that's a good idea for hover because you loose so much precision - it's fine on the legend since that's "far off"
Really what I'd want is the same outline rendering we have in re_Renderer driven space views....

@Wumpf Wumpf merged commit ffe8a10 into main Jan 31, 2024
40 of 41 checks passed
@Wumpf Wumpf deleted the andreas/select-plot-entity branch January 31, 2024 08:23
@abey79 abey79 changed the title Allow selection of entitites directly in the plot space view Allow selection of entities directly in the plot space view Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to select Scalar entity in TimeSeriesView Improve X-axis ticks spacing in timeseries space views
3 participants
@Wumpf @nikolausWest @emilk