Add experimental Dataframe Space View #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
force-pushed
the
antoine/table-space-view
branch
from
8128095 to
08923a8
Compare
abey79
changed the title
abey79
force-pushed
the
antoine/table-space-view
branch
from
03e865e to
c9adfe2
Compare
teh-cmc
approved these changes
Dec 12, 2023
crates/re_viewer_context/src/space_view/space_view_class_registry.rs
Outdated
Show resolved
Hide resolved
| .iter() | ||
| .flat_map(|entity| { | ||
| store | ||
| .all_components(&query.timeline, entity) |
There was a problem hiding this comment.
You've already made that same query just above!
Comment on lines
161
to
166
| get_component_with_instances( | ||
| store, | ||
| &latest_at_query, | ||
| &instance.entity_path, | ||
| *comp, | ||
| ) |
There was a problem hiding this comment.
all_instances).
All these get_component_instances queries should be done once at the start and put in a map, then everything can be done cheaply.
There was a problem hiding this comment.
As per our discussion yesterday, this is acceptable because the inner table closure is called only for the displayed rows. I added a comment to that effect.
emilk
reviewed
Dec 12, 2023
emilk
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a new kind of space view—called Dataframe Space View—which display the raw data of the entities added to it. This first iteration display data with the "latest at" semantics, with each rows corresponding to an entity instance.
This features is experimental and has plenty of usability issues (whose growing list is tracked in #4466). As a result, it is disabled by default and can be enabled in the options.
For the purpose of this feature flag, this PR adds support for de-registering a space view from the registry.
Checklist