Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "can't copy/cut on Safari" warning from the Getting Started guides #4300

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Remove the "can't copy/cut on Safari" warning from the Getting Started guides #4300

merged 2 commits into from
Dec 1, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 21, 2023 •
edited by emilk
Loading

What

egui 0.24 will fix the bug where coping from Safari was impossible:

This PR removes the related warnings in the in-app Getting Started guides.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 21, 2023
@abey79 abey79 added this to the 0.11 milestone Nov 21, 2023
@emilk emilk modified the milestones: 0.11, 0.12 Nov 27, 2023
@teh-cmc teh-cmc mentioned this pull request Nov 30, 2023
Merged
4 tasks
@abey79 abey79 removed the do-not-merge Do not merge this PR label Dec 1, 2023
@emilk
Copy link
Member

emilk commented Dec 1, 2023

Confirmed to work

@emilk emilk merged commit 275639c into main Dec 1, 2023
40 of 42 checks passed
@emilk emilk deleted the antoine/no-safari-warning branch December 1, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

Remove Safari copy-related warning from Quick Start guides
3 participants
@abey79 @emilk @teh-cmc