WIP: disconnect spaces when their categories differ #3790
Conversation
jleibs
force-pushed
the
jleibs/space_info_categories
branch
from
2c258ab to
12cd512
Compare
| } | ||
| } | ||
|
|
||
| // TODO(jleibs): These need to get pulled from a registry of some form |
There was a problem hiding this comment.
also ideally they're not in re_viewport but instead have this be governed by the heuristic method on the SpaceView trait. re_viewport knowing about re_types is kind of a hack
There was a problem hiding this comment.
Associating some kind of "Preferred SpaceInfoCategory" metadata in the schema registry is an interesting thought.
Related:
| // TODO(jleibs): Why not make everything interesting? | ||
| return true; |
There was a problem hiding this comment.
Much preferred. The whole idea of not having space_view at root be always a thing is from back then when we never allowed it in the first place.
The heuristics today tries to allow two ways of thinking and a mix of it right now: One where you have one scene at the root and one where you have many scenes each under a /thing. Back in the day we only had the latter.
What
Proof-of-concept mechanism to handle cases like: #3712
The basic idea here is to categorized space infos and treat them as disconnected when their categorization differs. Hits way too many edge-cases but useful to consider for proper solution.
Checklist