Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space-view screenshotting on Web #8264

Open
emilk opened this issue Dec 2, 2024 · 1 comment
Open

Space-view screenshotting on Web #8264

emilk opened this issue Dec 2, 2024 · 1 comment
Labels
egui Requires egui/eframe work enhancement New feature or request 🕸️ web regarding running the viewer in a browser

Comments

@emilk
Copy link
Member

emilk commented Dec 2, 2024 •
edited
Loading

#8258 introduced egui-based screenshotting of space views. However, it is not implemented on web. For that to work we need to:
@emilk emilk added enhancement New feature or request 🕸️ web regarding running the viewer in a browser egui Requires egui/eframe work labels Dec 2, 2024
@emilk emilk mentioned this issue Dec 2, 2024
Merged
1 task
emilk added a commit that referenced this issue Dec 3, 2024
@emilk @Wumpf
Space view screenshotting in native viewer (#8258)
16f0309 
### Related
* Closes #3941
* Uses emilk/egui#5416
* Uses emilk/egui#5426
* Follow-up: #8264

### What
Right-click the name of any space view to get the option to copy its
contents as a screenshot, or save it to disk:


![image](https://github.com/user-attachments/assets/0a0c5215-9042-4989-9e4a-62f76823588a)

-> 


![image](https://github.com/user-attachments/assets/ec222323-4692-4fd2-ae7b-2342996829a3)


#### Details
The implementation simply takes a full-screen screenshot and crops the
result.

The previous attempt (behind a feature-flag) only captured things that
were rendered with `re_renderer`, i.e. did not include any egui
elements, like labels. So it also only worked on spatial views. This PR
work on _all_ space views, and could also be extended to work on
containers etc.

### Limitations
Not yet implemented on web. See
#8264

### TODO
* [x] Point commit hash to egui `master`

---------

Co-authored-by: Andreas Reich <[email protected]>
@emilk emilk mentioned this issue Dec 16, 2024
Merged
emilk added a commit that referenced this issue Dec 16, 2024
@emilk
Update to latest egui (#8469)
b68b4e9 
### Related
* Part of #8454 (but not a
complete fix)
* Part of #8264 (will try to
implement later)
@emilk emilk mentioned this issue Dec 16, 2024
Merged
@emilk
Copy link
Member Author

emilk commented Dec 16, 2024

Wumpf pushed a commit that referenced this issue Dec 17, 2024
@emilk
Implement save-view-as-screenshot on web (#8472)
11c06b1 
### Related
* Part of #8264
* Using emilk/egui#5438

Still missing: copy screenshot to clipboard

Also fixes a crash when screenshotting graph views.

### Usage

![image](https://github.com/user-attachments/assets/88948342-8279-4bf6-9bc6-13722229dc44)

### Result
![Node-link
diagram](https://github.com/user-attachments/assets/b2ff8dd5-ae55-436a-9cd2-263eeb72a0df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
egui Requires egui/eframe work enhancement New feature or request 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emilk