Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rr.serve should be rr.serve_websocket, rr.connect should be rr.connect_tcp #7766

Closed
teh-cmc opened this issue Oct 16, 2024 · 3 comments · Fixed by #7906
Closed

rr.serve should be rr.serve_websocket, rr.connect should be rr.connect_tcp #7766

teh-cmc opened this issue Oct 16, 2024 · 3 comments · Fixed by #7906
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Oct 16, 2024

And similarly, rerun --serve should be rerun --serve-websocket (or something along these lines, you get the idea).

Users get understandably confused by this. They expect a serving process (rr.serve()) to be ready to accept connections from other processes (rr.connect()), except the two things are in reality completely unrelated: one is hosting a websocket server to be polled by the web-viewer, while the other is trying to connect to the TCP sdk comms pipeline.

See e.g. this thread: https://discord.com/channels/1062300748202921994/1295914647165210634

@teh-cmc teh-cmc added 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 😤 annoying Something in the UI / SDK is annoying to use user-request This is a pressing issue for one of our users labels Oct 16, 2024
@zehiko
Copy link
Contributor

zehiko commented Oct 16, 2024

+1, I ran into this confusion myself just yesterday

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 25, 2024

Yet another thing that would make documenting the app model (#919) easier.

@emilk
Copy link
Member

emilk commented Oct 25, 2024

Let's just rename these and keep the old names as deprecated redirects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants