Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native H.264 #7606

Closed
emilk opened this issue Oct 7, 2024 · 1 comment
Closed

Native H.264 #7606

emilk opened this issue Oct 7, 2024 · 1 comment
Assignees
@Wumpf
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself 🎞️ video
Milestone
0.20 - Maps, H.264

Comments

@emilk
Copy link
Member

emilk commented Oct 7, 2024 •
edited
Loading

Possible approaches
@emilk emilk added enhancement New feature or request 📺 re_viewer affects re_viewer itself 🎞️ video labels Oct 7, 2024
@emilk emilk self-assigned this Oct 8, 2024
@emilk emilk mentioned this issue Oct 8, 2024
Merged
6 tasks
emilk added a commit that referenced this issue Oct 8, 2024
@emilk
Refactor native video decoder for code reuse (#7641)
d90a697 
### What
* Part of #7606 

This refactors the native decoder so that we can easily slot in a
different native decoder (ffmpeg!).

The innermost trait is now `SyncDecoder` which gets pushed a chunk, and
blocks while producing frames (or errors). Around that is an
`AsyncDecoder` that runs the `SyncDecoder` on a background thread to
produce a non-blocking interface.
Finally in `re_renderer` there is the `NativeDecoder` that wraps
`SyncDecoder` and handles texture uploads.

There is a lot of code moved, but very little code actually _changed_.
It's just another layer of abstraction introduced.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7641?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7641?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7641)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
This was referenced Oct 9, 2024
Closed
Merged
emilk added a commit that referenced this issue Oct 10, 2024
@emilk
Small video-related refactor (#7660)
d66ce14 
### What
Some small improvements in service of coming ffmpeg stuff

* Extracted from #7658
* Part of #7606

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7660?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7660?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7660)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk emilk added this to the 0.20 - H.264, Undo milestone Oct 17, 2024
@emilk emilk assigned Wumpf and unassigned emilk Oct 31, 2024
@Wumpf
Copy link
Member

Wumpf commented Oct 31, 2024 •
edited
Loading

OpenH264 is fairly limited in what it can support, so we're leaning into

@Wumpf Wumpf closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself 🎞️ video
Projects
None yet
Milestone
0.20 - Maps, H.264
Development

Successfully merging a pull request may close this issue.

Native H.264 decoding using FFMPEG over CLI/IPC rerun-io/rerun
2 participants
@emilk @Wumpf