Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe view: sorting and primary column selection #7070

Open
Tracked by #4466
abey79 opened this issue Aug 6, 2024 · 2 comments
Open
Tracked by #4466

Dataframe view: sorting and primary column selection #7070

abey79 opened this issue Aug 6, 2024 · 2 comments
Assignees
@abey79 @gavrelina
Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Aug 6, 2024 •
edited
Loading

In time range mode, there are two "header" columns: time and entity path. It should be possible to:

  • select which one is the "primary" one (eg. appears first and is used for grouping)
  • choose the sort direction independently for both of them...
  • ...using an icon in the column header.

Currently, it's possible to choose the primary column, but sort order is not indepenent.

Here, time is primary, and both are sorted in ascending direction:
image



When fixing the UI for this issue, it would be a good time to also address:
@abey79 abey79 added the ui concerns graphical user interface label Aug 6, 2024
@abey79 abey79 self-assigned this Aug 6, 2024
This was referenced Aug 6, 2024
Open
Merged
@abey79 abey79 mentioned this issue Sep 3, 2024
Merged
6 tasks
abey79 added a commit that referenced this issue Sep 4, 2024
@abey79
Add point-of-view entity and component to the dataframe view's UI (#7331
fed60d4 
)

### What

- Part of: #7279

This PR updates the dataframe query override UI as per design in #7279,
in particular adding PoV entity and component.
- updated UI layout
- time boundaries default to `+∞`/`–∞` button which, when clicked, turn
into editable time drag value
- reset buttons to go back to the `∞` state
- auto-selection of PoV component based on PoV entity (picks a required
component for one of the entity archetypes)

**Note**:
- This is a pure UI PR. The PoV entity/component are not yet used at all
for the dataframe's content (that will be addressed in a follow-up PR
currently blocked on #7284).
- Ignore the ugly "Time range table order" part, this will be cleaned up
later (#7070)


https://github.com/user-attachments/assets/32151a1f-b0ca-4e99-99df-ea730451d4dc

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7331?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7331?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7331)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@abey79 abey79 added the feat-dataframe-view Everything related to the dataframe view label Sep 9, 2024
@abey79
Copy link
Member Author

abey79 commented Sep 10, 2024

This is only really needed if/when we do:

@gavrelina
Copy link
Member

will leave a proposal here to not forget it!

Screen.Recording.2024-09-11.at.11.47.29.mp4

@abey79 abey79 mentioned this issue Sep 12, 2024
Merged
6 tasks
emilk pushed a commit that referenced this issue Sep 16, 2024
@abey79
Remove the TimeRangeTableOrder blueprint structure, which is no lon…
c8855c7 
…ger used by the dataframe view (#7415)

### What

- closes #7390
- related #7070

What the title says☝🏻 This was dead code and a wart in the dataframe
view selection panel.

Table sorting is now covered by #7070 and blocked on proper support at
`re_dataframe` level.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7415?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7415?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7415)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

@gavrelina gavrelina

Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abey79 @gavrelina