Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand clickable area in blueprints list #2855

Closed
Tracked by #2670
martenbjork opened this issue Jul 28, 2023 · 2 comments
Closed
Tracked by #2670

Expand clickable area in blueprints list #2855

martenbjork opened this issue Jul 28, 2023 · 2 comments
Labels
ui concerns graphical user interface

Comments

@martenbjork
Copy link
Contributor

martenbjork commented Jul 28, 2023

It seems that the area indicated in red can't be clicked. However, it has a hover effect which indicated that it's clickable.

I found this confusing when I was quickly clicking through the items — sometimes my click wouldn't register.

Component 3 (1)
@abey79
Copy link
Member

abey79 commented Jul 28, 2023

I suspect that the area covered by the 2px expansion is not actually clickable. This control will need a complete rewrite I believe:

  • it needs the proper triangle (Use design system arrow icon across the app #2738)
  • it needs suppression of the expansion effect on the triangle
  • it needs better control the highlight area (which is negatively affected by suppressing the expansion, and is hard to work around)

@emilk emilk added the ui concerns graphical user interface label Aug 8, 2023
abey79 added a commit that referenced this issue Aug 29, 2023
### What

This PR back-ports `ListItem` into the blueprint tree UI. This includes
multiple fixes and additions to `ListItem` itself.

Note that this PR strictly replicates the current behaviour, which has
several issues:
- containers look inactive although they are active
- hidden elements look inactive although they are active
- cannot unhide one children of a hidden group
- hiding a container doesn't dim its children
- more generally, it would be nice to improve the visual distinction
between containers, space views, data group and data item (i.e. if you
_know_ what a space view vs. data group is, you'll find them, but the
tree UI does very little to actually _teach_ that distinction)

Fixes:
- #3044 
- #2946
- #2855

<img width="1274" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/b84512ea-cbd0-450f-aebb-1c8fb6aea98a">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3118) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3118)
- [Docs
preview](https://rerun.io/preview/a33ae6b49d223f5fb3ed15da9ff14740b1b4efae/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/a33ae6b49d223f5fb3ed15da9ff14740b1b4efae/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@abey79
Copy link
Member

abey79 commented Aug 30, 2023

Fixed by #3118

@abey79 abey79 closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants