Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ListItem in Blueprint tree UI #3044

Closed
abey79 opened this issue Aug 18, 2023 · 1 comment
Closed

Use ListItem in Blueprint tree UI #3044

abey79 opened this issue Aug 18, 2023 · 1 comment
Assignees
@abey79
Labels
ui concerns graphical user interface
Milestone
0.9 - Codegen, Ty...

Comments

@abey79
Copy link
Member

abey79 commented Aug 18, 2023

As the title says.

Fixes #2855
@abey79 abey79 added the ui concerns graphical user interface label Aug 18, 2023
@abey79 abey79 added this to the 0.9 milestone Aug 18, 2023
@abey79 abey79 mentioned this issue Aug 28, 2023
Merged
3 tasks
abey79 added a commit that referenced this issue Aug 29, 2023
@abey79
Use ListItem in blueprint tree UI (#3118)
86466ae 
### What

This PR back-ports `ListItem` into the blueprint tree UI. This includes
multiple fixes and additions to `ListItem` itself.

Note that this PR strictly replicates the current behaviour, which has
several issues:
- containers look inactive although they are active
- hidden elements look inactive although they are active
- cannot unhide one children of a hidden group
- hiding a container doesn't dim its children
- more generally, it would be nice to improve the visual distinction
between containers, space views, data group and data item (i.e. if you
_know_ what a space view vs. data group is, you'll find them, but the
tree UI does very little to actually _teach_ that distinction)

Fixes:
- #3044 
- #2946
- #2855

<img width="1274" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/b84512ea-cbd0-450f-aebb-1c8fb6aea98a">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3118) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3118)
- [Docs
preview](https://rerun.io/preview/a33ae6b49d223f5fb3ed15da9ff14740b1b4efae/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/a33ae6b49d223f5fb3ed15da9ff14740b1b4efae/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@abey79
Copy link
Member Author

abey79 commented Aug 30, 2023

Fixed by #3118

@abey79 abey79 closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
ui concerns graphical user interface
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

No branches or pull requests
1 participant
@abey79