Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add width/height properties to web viewer (#6636)
### What We now set the web viewer CSS width/height to some default values, which can be modified by the user. Setting them to empty strings is allowed to disable the default values completely, and allow styling the canvas through other means as before. This is meant as a mitigation for emilk/egui#4699 - by setting the CSS width/height to _something_, the canvas width/height attributes won't contribute to the display size of the canvas. Tested in https://github.com/rerun-io/web-viewer-example by manually linking the package ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6636?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6636?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6636) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
- Loading branch information