Skip to content

Commit

Permalink
Ci fixes (flaky test, missing unreleased-docs marker) (#7424)
Browse files Browse the repository at this point in the history
### What

* disable test run due to mixing of `send_columns` and `log`
* missing `unreleased` marker

### Checklist
* [x] check!

- [PR Build Summary](https://build.rerun.io/pr/7424)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
  • Loading branch information
Wumpf authored Sep 17, 2024
1 parent d9456a8 commit bfb67a6
Show file tree
Hide file tree
Showing 18 changed files with 48 additions and 37 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace rerun.archetypes;
/// \example archetypes/video_manual_frames title="Video with explicit frames" image="https://static.rerun.io/video_manual_frames/320a44e1e06b8b3a3161ecbbeae3e04d1ccb9589/1200w.png"
// TODO(#7368): Example and reference to `send_video_frames` API.
table AssetVideo (
"attr.docs.unreleased",
"attr.rerun.experimental"
) {
// --- Required ---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace rerun.archetypes;
/// \example archetypes/video_manual_frames title="Video with explicit frames" image="https://static.rerun.io/video_manual_frames/320a44e1e06b8b3a3161ecbbeae3e04d1ccb9589/1200w.png"
// TODO(#7368): Example and reference to `send_video_frames` API.
table VideoFrameReference (
"attr.docs.unreleased",
"attr.rerun.experimental"
){
// --- Required ---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ namespace rerun.components;

/// A path to an entity, usually to reference some data that is part of the target entity.
table EntityPath (
"attr.docs.unreleased",
"attr.arrow.transparent",
"attr.python.aliases": "str",
"attr.python.array_aliases": "str, Sequence[str]",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ namespace rerun.components;

/// Timestamp inside a [archetypes.AssetVideo].
struct VideoTimestamp (
"attr.docs.unreleased",
"attr.rust.derive": "Copy, PartialEq, Eq, Default",
"attr.rust.repr": "transparent",
"attr.rerun.experimental"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
namespace rerun.datatypes;

/// Specifies how to interpret the `video_time` field of a [datatypes.VideoTimestamp].
enum VideoTimeMode: ubyte{
enum VideoTimeMode: ubyte (
"attr.docs.unreleased"
) {
/// Invalid value. Won't show up in generated types.
Invalid = 0,

Expand All @@ -13,6 +15,7 @@ enum VideoTimeMode: ubyte{

/// Timestamp inside a [archetypes.AssetVideo].
struct VideoTimestamp (
"attr.docs.unreleased",
"attr.rust.derive": "Copy, PartialEq, Eq",
"attr.rerun.experimental"
) {
Expand Down
4 changes: 2 additions & 2 deletions crates/viewer/re_viewer/src/reflection/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions docs/content/reference/types/archetypes/asset_video.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/content/reference/types/components.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/content/reference/types/components/blob.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions docs/content/reference/types/components/entity_path.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/content/reference/types/components/media_type.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions docs/content/reference/types/components/video_timestamp.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/content/reference/types/datatypes.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/content/reference/types/datatypes/entity_path.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions docs/content/reference/types/datatypes/video_time_mode.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions docs/content/reference/types/datatypes/video_timestamp.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion docs/snippets/snippets.toml
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@ quick_start = [ # These examples don't have exactly the same implementation.
"py",
"rust",
]

"archetypes/video_manual_frames" = [ # This mixes `log` and `send_columns`. Since `log` is suspect to delays by the batcher, this test gets flaky.
"cpp",
"py",
"rust",
]

# `$config_dir` will be replaced with the absolute path of `docs/snippets`.
# Note that the snippet comparison tool will automatically run `/tests/assets/download_test_assets.py` before running the snippets.
Expand Down

0 comments on commit bfb67a6

Please sign in to comment.