More review comments

rerun-io · Dec 11, 2024 · b6753cd · b6753cd
1 parent 5242225
commit b6753cd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/crates/viewer/re_viewer_context/src/drag_and_drop.rs b/crates/viewer/re_viewer_context/src/drag_and_drop.rs
@@ -160,11 +160,15 @@ fn items_to_string<'a>(items: impl Iterator<Item = &'a Item>) -> String {
     count_and_names
         .into_iter()
         .filter_map(|(count, name_singular, name_plural)| {
-            if cnt > 0 {
+            if count > 0 {
                 Some(format!(
                     "{} {}",
-                    cnt,
-                    if cnt == 1 { name.0 } else { name.1 },
+                    re_format::format_uint(count),
+                    if count == 1 {
+                        name_singular
+                    } else {
+                        name_plural
+                    },
                 ))
             } else {
                 None

diff --git a/crates/viewer/re_viewer_context/src/viewer_context.rs b/crates/viewer/re_viewer_context/src/viewer_context.rs
@@ -175,12 +175,12 @@ impl ViewerContext<'_> {
                 selection_state.set_selection(selected_items.clone());
             }
 
-            let selection_contains_undraggable_items = self
+            let selection_may_be_dragged = self
                 .undraggable_items
                 .iter_items()
                 .all(|item| !selected_items.contains_item(item));
 
-            let payload = if selection_contains_undraggable_items {
+            let payload = if selection_may_be_dragged {
                 DragAndDropPayload::from_items(&selected_items)
             } else {
                 DragAndDropPayload::Invalid