solve open error handling todo

rerun-io · Jun 4, 2024 · ad33ad6 · ad33ad6
1 parent 384fc6b
commit ad33ad6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/crates/re_edit_ui/src/visual_bounds_2d.rs b/crates/re_edit_ui/src/visual_bounds_2d.rs
@@ -95,6 +95,7 @@ pub fn singleline_edit_visual_bounds_2d(
     ui: &mut egui::Ui,
     value: &mut VisualBounds2D,
 ) -> egui::Response {
+    // Not a lot of space in a single line, so edit width/height instead.
     let width = value.x_range.0[1] - value.x_range.0[0];
     let height = value.y_range.0[1] - value.y_range.0[0];
 

diff --git a/crates/re_space_view_spatial/src/ui_2d.rs b/crates/re_space_view_spatial/src/ui_2d.rs
@@ -2,6 +2,7 @@ use egui::{emath::RectTransform, pos2, vec2, Align2, Color32, Pos2, Rect, Shape,
 use macaw::IsoTransform;
 
 use re_entity_db::EntityPath;
+use re_log::ResultExt as _;
 use re_renderer::view_builder::{TargetConfiguration, ViewBuilder};
 use re_space_view::controls::{DRAG_PAN2D_BUTTON, RESET_VIEW_BUTTON_TEXT, ZOOM_SCROLL_MODIFIER};
 use re_types::{
@@ -43,7 +44,8 @@ fn ui_from_scene(
     let bounds_property = ViewProperty::from_archetype::<VisualBounds2D>(ctx, view_id);
     let bounds: blueprint_components::VisualBounds2D = bounds_property
         .component_or_fallback(view_class, view_state)
-        .unwrap_or_default(); // TODO: error?
+        .ok_or_log_error()
+        .unwrap_or_default();
     let mut bounds_rect: egui::Rect = bounds.into();
 
     // --------------------------------------------------------------------------