chore: replace error_with_details_on_hover(&

rerun-io · Nov 15, 2024 · a57b156 · a57b156
1 parent 257e00a
commit a57b156
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/crates/viewer/re_chunk_store_ui/src/arrow_ui.rs b/crates/viewer/re_chunk_store_ui/src/arrow_ui.rs
@@ -43,7 +43,7 @@ pub(crate) fn arrow_ui(ui: &mut egui::Ui, array: &dyn arrow2::array::Array) {
                 let mut string = String::new();
                 match display(&mut string, 0) {
                     Ok(_) => ui.monospace(&string),
-                    Err(err) => ui.error_with_details_on_hover(&err.to_string()),
+                    Err(err) => ui.error_with_details_on_hover(err.to_string()),
                 };
                 return;
             } else {

diff --git a/crates/viewer/re_chunk_store_ui/src/chunk_ui.rs b/crates/viewer/re_chunk_store_ui/src/chunk_ui.rs
@@ -146,7 +146,7 @@ impl ChunkUi {
                             crate::arrow_ui::arrow_ui(ui, &*data);
                         }
                         Some(Err(err)) => {
-                            ui.error_with_details_on_hover(&err.to_string());
+                            ui.error_with_details_on_hover(err.to_string());
                         }
                         None => {
                             ui.weak("-");
@@ -282,7 +282,7 @@ impl ChunkUi {
                     });
                 }
                 Err(err) => {
-                    ui.error_with_details_on_hover(&format!(
+                    ui.error_with_details_on_hover(format!(
                         "Failed to convert to tqransport: {err}"
                     ));
                 }

diff --git a/crates/viewer/re_data_ui/src/video.rs b/crates/viewer/re_data_ui/src/video.rs
@@ -40,7 +40,7 @@ pub fn video_result_ui(
         Err(err) => {
             let error_message = format!("Failed to load video: {err}");
             if ui_layout.is_single_line() {
-                ui.error_with_details_on_hover(&error_message);
+                ui.error_with_details_on_hover(error_message);
             } else {
                 ui.error_label(error_message);
             }

diff --git a/crates/viewer/re_space_view_dataframe/src/display_record_batch.rs b/crates/viewer/re_space_view_dataframe/src/display_record_batch.rs
@@ -254,7 +254,7 @@ impl DisplayColumn {
                             ui.label(timeline.typ().format(timestamp, ctx.app_options.time_zone));
                         }
                         Err(err) => {
-                            ui.error_with_details_on_hover(&err.to_string());
+                            ui.error_with_details_on_hover(err.to_string());
                         }
                     }
                 } else {

diff --git a/crates/viewer/re_space_view_spatial/src/picking_ui_pixel.rs b/crates/viewer/re_space_view_spatial/src/picking_ui_pixel.rs
@@ -178,7 +178,7 @@ pub fn show_zoomed_image_region(
         interaction_id,
         center_texel,
     ) {
-        ui.error_with_details_on_hover(&err.to_string());
+        ui.error_with_details_on_hover(err.to_string());
     }
 }
 

diff --git a/crates/viewer/re_viewer_context/src/component_ui_registry.rs b/crates/viewer/re_viewer_context/src/component_ui_registry.rs
@@ -411,7 +411,7 @@ impl ComponentUiRegistry {
         // Also, it allows us to slice the array without cloning any elements.
         let Some(array) = unit.component_batch_raw(&component_name) else {
             re_log::error_once!("Couldn't get {component_name}: missing");
-            ui.error_with_details_on_hover(&format!("Couldn't get {component_name}: missing"));
+            ui.error_with_details_on_hover(format!("Couldn't get {component_name}: missing"));
             return;
         };