recording storage details include bucket name

rerun-io · Oct 9, 2024 · 9d9ba96 · 9d9ba96
1 parent 16933bd
commit 9d9ba96
Show file tree

Hide file tree

Showing 2 changed files with 161 additions and 79 deletions.
diff --git a/crates/store/re_storage_types/proto/rerun/v0/storage.proto b/crates/store/re_storage_types/proto/rerun/v0/storage.proto
@@ -21,11 +21,16 @@ message RecordingId {
 
 message RegisterRecordingsRequest {
     string description = 1;
-    string storage_url = 2;
+    ObjectStorage obj_storage = 2;
     // TODO should this be auto-discoverable?
     RecordingType typ = 3;
 }
 
+message ObjectStorage {
+    string bucket_name = 1;
+    string url = 2;
+}
+
 message RegisterRecordingsResponse {
     // Note: this implies we read the record (for example go through entire .rrd file
     // chunk by chunk) and extract the metadata. So we might want to 1/ not do this i.e.