self review

crates/re_query_cache/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "re_query_cache"
 authors.workspace = true
-description = "Temporary crate meant to replace re_query_cache"
+description = "Caching datastructures for re_query"
 edition.workspace = true
 homepage.workspace = true
 include.workspace = true

crates/re_query_cache/README.md

@@ -1,5 +1,10 @@
 # re_query_cache
 
-Temporary crate for implementing the new cached data APIs. Not published.
+Part of the [`rerun`](https://github.com/rerun-io/rerun) family of crates.
 
-Will replace `re_query_cache` when ready.
+[![Latest version](https://img.shields.io/crates/v/re_query_cache.svg)](https://crates.io/crates/re_query_cache)
+[![Documentation](https://docs.rs/re_query/badge.svg)](https://docs.rs/re_query)
+![MIT](https://img.shields.io/badge/license-MIT-blue.svg)
+![Apache](https://img.shields.io/badge/license-Apache-blue.svg)
+
+Caching datastructures for `re_query`.

crates/re_query_cache/src/flat_vec_deque.rs

@@ -111,8 +111,7 @@ impl<T: SizeBytes + 'static> ErasedFlatVecDeque for FlatVecDeque<T> {
 /// optimizes for writes.
 ///
 /// You can think of this as the native/deserialized version of an Arrow `ListArray`.
-/// This is particularly useful when working with many small arrays of data (e.g. Rerun's
-/// `TimeSeriesScalar`s).
+/// This is particularly useful when working with many small arrays of data (e.g. Rerun's `Scalar`s).
 //
 // TODO(cmc): We could even use a bitmap for T=Option<Something>, which would bring this that much
 // closer to a deserialized version of an Arrow array.

crates/re_query_cache/tests/latest_at.rs

@@ -170,7 +170,7 @@ fn splatted_query() {
 }
 
 #[test]
-fn invalidation_xxx() {
+fn invalidation() {
     let entity_path = "point";
 
     let test_invalidation = |query: LatestAtQuery,

crates/re_space_view_spatial/src/visualizers/results_ext.rs

@@ -80,15 +80,11 @@ impl CachedRangeResultsExt for CachedRangeResults {
         // TODO(#5607): what should happen if the promise is still pending?
         let (front_status, back_status) = results.status();
         match front_status {
-            PromiseResult::Error(err) => {
-                return Err(re_query_cache::QueryError::Other(err.into()))
-            }
+            PromiseResult::Error(err) => return Err(re_query_cache::QueryError::Other(err.into())),
             PromiseResult::Pending | PromiseResult::Ready(_) => {}
         }
         match back_status {
-            PromiseResult::Error(err) => {
-                return Err(re_query_cache::QueryError::Other(err.into()))
-            }
+            PromiseResult::Error(err) => return Err(re_query_cache::QueryError::Other(err.into())),
             PromiseResult::Pending | PromiseResult::Ready(_) => {}
         }
 
@@ -134,15 +130,11 @@ impl CachedRangeResultsExt for CachedLatestAtResults {
         // TODO(#5607): what should happen if the promise is still pending?
         let (front_status, back_status) = data.status();
         match front_status {
-            PromiseResult::Error(err) => {
-                return Err(re_query_cache::QueryError::Other(err.into()))
-            }
+            PromiseResult::Error(err) => return Err(re_query_cache::QueryError::Other(err.into())),
             PromiseResult::Pending | PromiseResult::Ready(_) => {}
         }
         match back_status {
-            PromiseResult::Error(err) => {
-                return Err(re_query_cache::QueryError::Other(err.into()))
-            }
+            PromiseResult::Error(err) => return Err(re_query_cache::QueryError::Other(err.into())),
             PromiseResult::Pending | PromiseResult::Ready(_) => {}
         }