Skip to content

Commit

Permalink
add a comment pointing to how common it is to change colors depending on
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Oct 11, 2024
1 parent 5740e2f commit 6294334
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions crates/store/re_video/src/decode/av1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,9 @@ fn color_primaries(debug_name: &str, picture: &dav1d::Picture) -> ColorPrimaries
// ColorPrimaries::Bt601
// }
//
// This is also what the mpv player does (and probably others):
// https://wiki.x266.mov/docs/colorimetry/primaries#2-unspecified
//
// …then again, eyeballing VLC it looks like it just always assumes BT.709.
// The handwavy test case employed here was the same video in low & high resolution
// without specified primaries. Both looked the same.
Expand Down

0 comments on commit 6294334

Please sign in to comment.