dataframe view: propagate changes

rerun-io · Oct 10, 2024 · 4161c58 · 4161c58
1 parent b586c91
commit 4161c58
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/crates/viewer/re_space_view_dataframe/src/space_view_class.rs b/crates/viewer/re_space_view_dataframe/src/space_view_class.rs
@@ -143,23 +143,26 @@ mode sets the default time range to _everything_. You can override this in the s
             SparseFillStrategy::None
         };
 
-        let view_columns = query_engine.schema_for_view_contents(&view_contents);
-        let selected_columns =
-            view_query.apply_column_visibility_to_view_columns(ctx, &view_columns)?;
-
-        let dataframe_query = re_chunk_store::QueryExpression {
+        let mut dataframe_query = re_chunk_store::QueryExpression {
             view_contents: Some(view_contents),
             filtered_index: view_query.timeline(ctx)?,
             filtered_index_range: Some(view_query.filter_by_range()?),
             filtered_point_of_view: view_query.filter_by_event()?,
             sparse_fill_strategy,
-            selection: selected_columns,
+            selection: None,
 
             // not yet unsupported by the dataframe view
             filtered_index_values: None,
             using_index_values: None,
+            include_semantically_empty_columns: false,
+            include_indicator_columns: false,
+            include_tombstone_columns: false,
         };
 
+        let view_columns = query_engine.schema_for_query(&dataframe_query);
+        dataframe_query.selection =
+            view_query.apply_column_visibility_to_view_columns(ctx, &view_columns)?;
+
         let query_handle = query_engine.query(dataframe_query);
 
         let hide_column_actions =