Skip to content

Commit

Permalink
Do not cache static entries in the query-time latest-at cache (#7654)
Browse files Browse the repository at this point in the history
Manually tested on some known user-provided problematic dataset. Works
as advertised.

* Fixes #7552
  • Loading branch information
teh-cmc authored Oct 9, 2024
1 parent a98d534 commit 4135249
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion crates/store/re_query/src/latest_at.rs
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,9 @@ impl LatestAtCache {
})
.clone();

if query.at() != data_time {
// NOTE: Queries that return static data are much cheaper to run, and polluting the query-time cache
// just to point to the static tables again and again is very wasteful.
if query.at() != data_time && !data_time.is_static() {
per_query_time
.entry(query.at())
.or_insert_with(|| LatestAtCachedChunk {
Expand Down

0 comments on commit 4135249

Please sign in to comment.