Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't clear scalars in
face tracking
example (#4950)
This is what caused the deadlocks/crashes we were after (which I'm glad it did -- those have been fixed in #4949). Even though they are not a problem anymore, I'm not sure why they're here to begin with? Clearing scalars does nothing unless you specifically intend to use them with latest-at queries (i.e. not plots, which isn't the case here), otherwise it's just inefficient with no upside (which I'd rather not teach users). Am I missing something? :thinking: --- I've updated the code to only clear faces when they disappear. I might come up with a follow up PR soon so that the timeseries view interprets those clears as plot breakpoints.
- Loading branch information