Skip to content

Commit

Permalink
include separate rec id in the register metadata response
Browse files Browse the repository at this point in the history
  • Loading branch information
zehiko committed Nov 4, 2024
1 parent 0cf41e5 commit 1bcd40b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ message RecordingMetadata {
}

message RegisterRecordingResponse {
RecordingId id = 1;
// Note / TODO(zehiko): this implies we read the record (for example go through entire .rrd file
// chunk by chunk) and extract the metadata. So we might want to 1/ not do this i.e.
// only do it as part of explicit GetMetadata request or 2/ do it if Request has "include_metadata=true"
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1bcd40b

Please sign in to comment.