Skip to content

Commit

Permalink
re_types_blueprint -> re_types::blueprint (#8419)
Browse files Browse the repository at this point in the history
Having blueprint types in a separate crate makes everything more
complicated, for little to no benefits as far as I can tell.
It is particularly bad when reflection is involved, as it introduces
unavoidable dependency cycles.

This PR merges them.
  • Loading branch information
teh-cmc authored Dec 12, 2024
1 parent 71afae7 commit 1a9135d
Show file tree
Hide file tree
Showing 61 changed files with 104 additions and 353 deletions.
11 changes: 5 additions & 6 deletions ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ Of course, this will only take us so far. In the future we plan on caching queri
Here is an overview of the crates included in the project:

<picture>
<img src="https://static.rerun.io/architecture/1cc75ea6e625e77e94996b1c9aef8a0cca08bfcc/full.png" alt="">
<source media="(max-width: 480px)" srcset="https://static.rerun.io/architecture/1cc75ea6e625e77e94996b1c9aef8a0cca08bfcc/480w.png">
<source media="(max-width: 768px)" srcset="https://static.rerun.io/architecture/1cc75ea6e625e77e94996b1c9aef8a0cca08bfcc/768w.png">
<source media="(max-width: 1024px)" srcset="https://static.rerun.io/architecture/1cc75ea6e625e77e94996b1c9aef8a0cca08bfcc/1024w.png">
<source media="(max-width: 1200px)" srcset="https://static.rerun.io/architecture/1cc75ea6e625e77e94996b1c9aef8a0cca08bfcc/1200w.png">
<img src="https://static.rerun.io/crates/8044a2d9cf4e26687eaaf43352c391cb7aac557b/full.png" alt="">
<source media="(max-width: 480px)" srcset="https://static.rerun.io/crates/8044a2d9cf4e26687eaaf43352c391cb7aac557b/480w.png">
<source media="(max-width: 768px)" srcset="https://static.rerun.io/crates/8044a2d9cf4e26687eaaf43352c391cb7aac557b/768w.png">
<source media="(max-width: 1024px)" srcset="https://static.rerun.io/crates/8044a2d9cf4e26687eaaf43352c391cb7aac557b/1024w.png">
<source media="(max-width: 1200px)" srcset="https://static.rerun.io/crates/8044a2d9cf4e26687eaaf43352c391cb7aac557b/1200w.png">
</picture>


Expand Down Expand Up @@ -168,7 +168,6 @@ Update instructions:
| re_protos | Rerun remote store gRPC API types |
| re_query | Querying data in the re_chunk_store |
| re_types | The built-in Rerun data types, component types, and archetypes. |
| re_types_blueprint | The core traits and types that power Rerun's Blueprint sub-system. |


### Low-level store
Expand Down
17 changes: 0 additions & 17 deletions Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5698,7 +5698,6 @@ dependencies = [
"re_log_types",
"re_tracing",
"re_types",
"re_types_blueprint",
"re_types_core",
"re_ui",
"re_viewer_context",
Expand Down Expand Up @@ -6295,7 +6294,6 @@ dependencies = [
"re_log_types",
"re_tracing",
"re_types",
"re_types_blueprint",
"re_types_core",
"re_ui",
"re_view",
Expand Down Expand Up @@ -6423,18 +6421,6 @@ dependencies = [
"uuid",
]

[[package]]
name = "re_types_blueprint"
version = "0.21.0-alpha.1+dev"
dependencies = [
"arrow",
"once_cell",
"re_arrow2",
"re_tracing",
"re_types",
"re_types_core",
]

[[package]]
name = "re_types_builder"
version = "0.21.0-alpha.1+dev"
Expand Down Expand Up @@ -6828,7 +6814,6 @@ dependencies = [
"re_time_panel",
"re_tracing",
"re_types",
"re_types_blueprint",
"re_types_core",
"re_ui",
"re_video",
Expand Down Expand Up @@ -6932,7 +6917,6 @@ dependencies = [
"re_renderer",
"re_tracing",
"re_types",
"re_types_blueprint",
"re_ui",
"re_view",
"re_viewer_context",
Expand All @@ -6957,7 +6941,6 @@ dependencies = [
"re_log_types",
"re_tracing",
"re_types",
"re_types_blueprint",
"re_types_core",
"re_ui",
"re_viewer_context",
Expand Down
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ re_log_types = { path = "crates/store/re_log_types", version = "=0.21.0-alpha.1"
re_query = { path = "crates/store/re_query", version = "=0.21.0-alpha.1", default-features = false }
re_sdk_comms = { path = "crates/store/re_sdk_comms", version = "=0.21.0-alpha.1", default-features = false }
re_types = { path = "crates/store/re_types", version = "=0.21.0-alpha.1", default-features = false }
re_types_blueprint = { path = "crates/store/re_types_blueprint", version = "=0.21.0-alpha.1", default-features = false }
re_types_core = { path = "crates/store/re_types_core", version = "=0.21.0-alpha.1", default-features = false }
re_ws_comms = { path = "crates/store/re_ws_comms", version = "=0.21.0-alpha.1", default-features = false }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ namespace rerun.blueprint.archetypes;

/// The description of a container.
table ContainerBlueprint (
"attr.rerun.scope": "blueprint",
"attr.rust.override_crate": "re_types_blueprint"
"attr.rerun.scope": "blueprint"
) {
// --- Required ---

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ namespace rerun.blueprint.archetypes;
/// Shared state for the 3 collapsible panels.
table PanelBlueprint (
"attr.rerun.scope": "blueprint",
"attr.rust.derive": "Default",
"attr.rust.override_crate": "re_types_blueprint"
"attr.rust.derive": "Default"
) {
// --- Required ---

// --- Optional ---

/// Current state of the panels.
state: rerun.blueprint.components.PanelState ("attr.rerun.component_optional", nullable, order: 1000);

// TODO(jleibs): Add a float to track how expanded the panel is.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ namespace rerun.blueprint.archetypes;
/// The top-level description of the viewport.
table ViewportBlueprint (
"attr.rerun.scope": "blueprint",
"attr.rust.derive": "Default",
"attr.rust.override_crate": "re_types_blueprint"
"attr.rust.derive": "Default"
) {
// --- Required ---

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ namespace rerun.blueprint.components;
/// Whether the viewport layout is determined automatically.
struct AutoLayout (
"attr.arrow.transparent",
"attr.rerun.scope": "blueprint",
"attr.python.aliases": "bool",
"attr.rerun.scope": "blueprint",
"attr.rust.derive": "Copy",
"attr.rust.override_crate": "re_types_blueprint",
"attr.rust.repr": "transparent",
"attr.rust.tuple_struct"
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ struct AutoViews (
"attr.rerun.scope": "blueprint",
"attr.python.aliases": "bool",
"attr.rust.derive": "Copy, Default, PartialEq, Eq, PartialOrd, Ord",
"attr.rust.override_crate": "re_types_blueprint",
"attr.rust.repr": "transparent",
"attr.rust.tuple_struct"
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ namespace rerun.blueprint.components;

/// The kind of a blueprint container (tabs, grid, …).
enum ContainerKind: ubyte (
"attr.rerun.scope": "blueprint",
"attr.rust.override_crate": "re_types_blueprint"
"attr.rerun.scope": "blueprint"
) {
/// Invalid value. Won't show up in generated types.
Invalid = 0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ namespace rerun.blueprint.components;
table GridColumns (
"attr.rerun.scope": "blueprint",
"attr.python.aliases": "int",
"attr.rust.derive": "Default, PartialEq, Eq, PartialOrd, Ord",
"attr.rust.override_crate": "re_types_blueprint"
"attr.rust.derive": "Default, PartialEq, Eq, PartialOrd, Ord"
) {
/// The number of columns.
columns: rerun.datatypes.UInt32 (order: 100);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ namespace rerun.blueprint.components;
table RootContainer (
"attr.rerun.scope": "blueprint",
"attr.python.aliases": "npt.NDArray[np.uint8], npt.ArrayLike, Sequence[int], bytes",
"attr.rust.derive": "Default",
"attr.rust.override_crate": "re_types_blueprint",
"attr.rust.repr": "transparent"
"attr.rust.derive": "Default"
) {
/// `ContainerId` for the root.
id: rerun.datatypes.Uuid (order: 100);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ namespace rerun.blueprint.components;
table ViewMaximized (
"attr.rerun.scope": "blueprint",
"attr.python.aliases": "npt.NDArray[np.uint8], npt.ArrayLike, Sequence[int], bytes",
"attr.rust.derive": "Default",
"attr.rust.override_crate": "re_types_blueprint",
"attr.rust.repr": "transparent"
"attr.rust.derive": "Default"
) {
view_id: rerun.datatypes.Uuid (order: 100);
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ table VisualizerOverrides (
"attr.python.array_aliases": "str",
"attr.rerun.scope": "blueprint",
"attr.rust.derive": "PartialEq, Eq, PartialOrd, Ord, Default",
"attr.rust.repr": "transparent",
"attr.rust.override_crate": "re_types_blueprint"
"attr.rust.repr": "transparent"
) {
/// Names of the visualizers that should be active.
visualizers: rerun.blueprint.datatypes.Utf8List (order: 100);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ table Utf8List (
"attr.rerun.scope": "blueprint",
"attr.rust.derive": "PartialEq, Eq, PartialOrd, Ord, Default, Hash",
"attr.rust.repr": "transparent",
"attr.rust.tuple_struct",
"attr.rust.override_crate": "re_types_blueprint"
"attr.rust.tuple_struct"
) {
value: [string] (order: 100);
}
3 changes: 3 additions & 0 deletions crates/store/re_types/src/blueprint/archetypes/.gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions crates/store/re_types/src/blueprint/archetypes/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions crates/store/re_types/src/blueprint/components/.gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use re_types::datatypes::Bool;
use crate::datatypes::Bool;

use super::AutoLayout;

Expand Down
Loading

0 comments on commit 1a9135d

Please sign in to comment.