Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: replace files editor #364

Merged
merged 1 commit into from
Jul 17, 2024
Merged

documents: replace files editor #364

merged 1 commit into from
Jul 17, 2024

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 10, 2024 •
edited
Loading

image

@jma jma force-pushed the maj-new-files branch from e7f8ddb to e1619a3 Compare July 10, 2024 06:21
@jma jma changed the title Maj new files documents: replace files editor Jul 10, 2024
@jma jma force-pushed the maj-new-files branch from e1619a3 to 3a11b33 Compare July 10, 2024 06:28
@jma jma marked this pull request as ready for review July 10, 2024 06:28
@jma jma requested review from Garfield-fr and PascalRepond July 10, 2024 06:28
@jma jma force-pushed the maj-new-files branch from 3a11b33 to a245af8 Compare July 10, 2024 11:41
Garfield-fr
Garfield-fr approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@Garfield-fr Garfield-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're not doing any tests, I think it's a good idea to delete the tests file.

projects/sonar/src/app/record/files/file-item/file-item.component.html Outdated Show resolved Hide resolved
projects/sonar/src/app/record/files/upload-files/upload-files.component.html Outdated Show resolved Hide resolved
projects/sonar/src/app/record/files/upload-files/upload-files.component.html Outdated Show resolved Hide resolved
projects/sonar/src/app/record/files/upload-files/upload-files.component.html Outdated Show resolved Hide resolved
projects/sonar/src/app/record/files/upload-files/upload-files.component.html Outdated Show resolved Hide resolved
projects/sonar/src/app/record/files/file-item/file-item.component.html Outdated Show resolved Hide resolved
projects/sonar/src/app/record/files/upload-files/upload-files.component.html Outdated Show resolved Hide resolved
projects/sonar/src/app/record/files/upload-files/upload-files.component.html Outdated Show resolved Hide resolved
@jma jma force-pushed the maj-new-files branch from a245af8 to d4fb956 Compare July 15, 2024 09:31
@jma
documents: replace files editor
fadfc25 
* Uses primeng as files editor.
* Adds drag and drop properties.
* Removes useless informations.
* Fixes several issues for file versionning.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-new-files branch from d4fb956 to fadfc25 Compare July 15, 2024 09:57
PascalRepond
PascalRepond approved these changes Jul 15, 2024
View reviewed changes
package.json
@@ -42,10 +42,10 @@
"@angular/platform-browser-dynamic": "^17.3.10",
"@angular/router": "^17.3.10",
"@biesbjerg/ngx-translate-extract-marker": "^1.0.0",
"@ngx-formly/core": "^6.3.3",
"@ngx-formly/primeng": "^6.3.3",
"@ngx-formly/core": "6.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v6.3.6 is available and fixes some issues, maybe good to test

@jma jma merged commit ec5037d into rero:angular-17 Jul 17, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @Garfield-fr @PascalRepond