concepts: Add GND #170
Merged
concepts: Add GND #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rerowep
commented
Jul 27, 2024
•
rerowep
commented
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
12 times, most recently
from
52c773e to
0d8143e
Compare
PascalRepond
requested changes
Jul 30, 2024
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
3 times, most recently
from
3845d31 to
d6ee050
Compare
rero_mef/places/mef/mappings/v7/places_mef/mef-place-v0.0.1.json
Outdated
Show resolved
Hide resolved
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
2 times, most recently
from
1d7a630 to
3290a92
Compare
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
3 times, most recently
from
ea6d9f8 to
49cee49
Compare
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
2 times, most recently
from
48c9a18 to
3e508da
Compare
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
6 times, most recently
from
ca3b79d to
4fa6754
Compare
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
10 times, most recently
from
6a35200 to
65a4528
Compare
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
4 times, most recently
from
bdaf1ab to
da016d5
Compare
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
from
da016d5 to
8a1297c
Compare
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
4 times, most recently
from
8773ce9 to
1d8db05
Compare
jma
approved these changes
Oct 24, 2024
rero_mef/concepts/api.py
Outdated
| if idref_pids := [hit.pid for hit in query.source("pid").scan()]: | ||
| # get latest IDREF MEF data. | ||
| mef_data = ConceptMefRecord.get_latest( | ||
| pid_type="idref", pid=idref_pids[0] |
There was a problem hiding this comment.
If you have only one result you can use .pop on line 88.
* Dependencies update. * Deletes "identifier" from agents. * Adds GND to concepts. * Corrects GND for places * Adds IDREF bf:Temporal for 008 Tz5. * Adds IDREF bf:Topic for 008 Td5. Co-Authored-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
wep-concepts-add-gnd
branch
from
1d8db05 to
f41169a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.