Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared: enable translations #1052

Merged
merged 1 commit into from
Oct 10, 2023
Merged

shared: enable translations #1052

merged 1 commit into from
Oct 10, 2023

Conversation

jma
Copy link
Contributor

@jma jma commented Oct 9, 2023

  • Adds cli commands to extract and update translations.
  • Copies shared assets to the app projects.
  • Fixes assets pathes with the node dev server.

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma jma force-pushed the maj-shared-translations branch 2 times, most recently from 3a6871d to cc85e87 Compare October 9, 2023 13:32
@jma @Garfield-fr
shared: enable translations
cb8c152 
- Adds cli commands to extract and update translations.
- Copies shared assets to the app projects.
- Fixes assets pathes with the node dev server.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@jma jma marked this pull request as ready for review October 9, 2023 14:39
@jma jma force-pushed the maj-shared-translations branch from cc85e87 to cb8c152 Compare October 9, 2023 14:40
@PascalRepond PascalRepond merged commit 7ae8dd5 into rero:staging Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @Garfield-fr @PascalRepond